Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple asset types to be graphable #273

Open
cburroughs opened this issue Mar 9, 2015 · 2 comments
Open

allow multiple asset types to be graphable #273

cburroughs opened this issue Mar 9, 2015 · 2 comments

Comments

@cburroughs
Copy link
Contributor

Currently the isGraphable check looks someting like asset.isServerNode && asset.getHostnameMetaValue.isDefined. I would like to have graphs for vms/containers/some-other-non-physical server thing.

Making isGraphable a property of the asset type seemed like a reasonable course.

@byxorna
Copy link
Contributor

byxorna commented Mar 9, 2015

What would the isGraphable property actually look at? Probably would be best to push this into a config so you can specify the asset types you want to be graphable, and the attributes required on them.

@cburroughs
Copy link
Contributor Author

I was thinking it would be an attribute of the Asset Type, but now that I look it doesn't seem that Asset Type's have attributes. Maybe they should? But that seems like a larger change then the config based approach.

@yl3w yl3w added this to the Release 2.0 milestone May 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants