New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Will update gems #144
Will update gems #144
Changes from 7 commits
96d4fdc
1524bc8
06329a2
44b26bd
2969489
db0e678
3281c1a
a5fdc76
dd568ba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
0.2.11 | ||
0.2.12 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we remove this file? No need for it anymore, we dont read from it after jeweler was ripped out. (dont forget to remove from gemspec files list as well.) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All of the gems have it - are you comfortable with us removing it from all -William Richard On Wed, Apr 9, 2014 at 10:11 AM, Gabe Conradi notifications@github.comwrote:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the gemspec doesnt read that file in, then yea. I dont know what purpose it serves. @dallasmarlow There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @byxorna @Primer42 agreed, as much as i like blake this is an artifact of his that should be removed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The version file does not appear to be totally unused in all cases. For collins_shell, and collins_notify, blake appears to have used them There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Primer42 i'm a bit confused here, the page you linked to has an example of programmatically retrieving the version from the gemspec of a loaded gem. @byxorna and myself are just suggesting to keep the library version only in the gemspec to avoid these different files from conflicting. the VERSION file is currently not used in that project, if you really wanted to keep the VERSION files around for some reason then you would just want to have the gemspec read it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dallasmarlow @Primer42 is saying that the collins-shell and collins-notify libraries read the @Primer42 that suggestion is specific to rubygems. We dont want to force users of these gems to have rubygems installed, rather than another method (i.e. managing For collins_shell, its more integrated, and it looks like he is already using Gem to figure out what the latest gem is for comparison. Unsure what to do there. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @byxorna yep, you summarized what I was trying to say better than I was saying it :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dallasmarlow @byxorna how does this PR look now? Reading the version from the file, rather than having it hard coded in a few places? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was thinking just
File.read('VERSION').strip