Gabe optional ipmi power restrictions #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the tests failed. I reran them thru Travis and they passed :/ Ill update this branch to trigger a new build. |
byxorna
force-pushed
the
gabe-optional-ipmi-power-restrictions
branch
from
89b6e90
to
3c5a2dd
Compare
|
There is a flaky test mostly around solr index updates when on travis. Takes some time for indexes to update causing some tests to fail (some times) |
|
LGTM |
|
👍 |
|
This looks fine in itself, however I see an exception being thrown please test what happens in the gui for |
|
@maddalab I have tested and it works as expected (the exception percolates up to the UI, just like if there is a timeout.) |
byxorna
added a commit
that referenced
this pull request
Dec 16, 2015
…ions Gabe optional ipmi power restrictions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Primer42 @maddalab @schallert @roymarantz @tumblr/systems
This allows collins to perform power commands on assets that do not have IPMI Information configured, if you set
powermanagement.allowAssetsWithoutIpmi = true.