Added docs explaining how to cut a collins release #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byxorna
approved these changes
Jan 10, 2017
roymarantz
reviewed
Jan 11, 2017
| - [ ] Check out the collins code in an environment running jdk 7 with the unlimited strength JCE configured correctly, and play activator checked out in the correct location (`$HOME/src/activator-1.3.6-minimal/activator`). Run `scripts/package.sh` and attach the resulting zip to the release, and name it `collins-v<version number>.zip`. | ||
| - [ ] Do the previous step but in an environment with jdk 8. Attach the zip to the release, and title it `collins-v<version number>-jdk8.zip`. | ||
| - [ ] Save, but do not publish, the draft. If you want to get proofreading for your release text, this is the right time to do it. | ||
| - [ ] Cut a new branch off of master. Copy the text of the release into the [CHANGELOG.md](https://github.com/tumblr/collins/blob/master/CHANGELOG.md) file. Open a PR and get thumbs. See https://github.com/tumblr/collins/pull/490 for an example PR. |
There was a problem hiding this comment.
Shouldn't this step be removed if we are moving to github Release only?
I see that you say so below. Lets just drop CHANGELOG.md on the next release!
There was a problem hiding this comment.
Yeah I left it in there since I likely will not be running the next release - if that's the way we want to go, then whomever is doing it next can make those changes.
roymarantz
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tumblr/collins RFR