AddressPool name conversion should always handle defaultPoolName correctly #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416
This makes sure that we always map the pool name of an
AddressPoolto theDefaultPoolNameif necessary, to avoid referring to implicit pools as""some places, and byDefaultPoolNamein others. The specific way this manifested was IP allocation requests for the default pool name (i.e. by usingc.ipaddress_allocate!(:mytag, 'DEFAULT')would fail ifipAddress.defaultPoolName=DEFAULT, despite there being a pool with that name.I ran into this deploying a collins instance into a topology that had only a single L2 network. I attempted to use the default pool, but found I was unable to allocate IPs from it until I renamed it.
NOTE: i have some unit tests to confirm this behavior, but I am unable to figure out how to override play configuration with
WithApplication(FakeApplication(Map(additionalConfigHere)))in specs. Ill keep poking at it, but the change here has been manually verified and confirmed to fix #416.@qx-xp @roymarantz @defect @michaeljs1990