Add go mod support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komapa
approved these changes
Mar 11, 2019
|
Yeah, this is awesome. Haven't been able to try it out much but definitely appreciated! Unless someone else gets to it before me I'll check it out late this week or early next week. Unrelated, we might want to check if we can remove @schallert 's fork and just use the upstream. To be honest, I don't personally remember why it needed to be forked. |
alex-laties
approved these changes
Mar 12, 2019
defect
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the way the golang community is going for dependency management. The biggest thing is that it makes it really easy to test local changes or forks of this repo for other modules using go mod as well. I have been locally generating this file for a while so I can use the following feature when making changes to the go-client locally.