Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for initContainers #7

Closed
byxorna opened this issue Mar 6, 2019 · 5 comments
Closed

add support for initContainers #7

byxorna opened this issue Mar 6, 2019 · 5 comments
Assignees

Comments

@byxorna
Copy link
Contributor

byxorna commented Mar 6, 2019

What's going on?

We should support initContainers in our injection configs

#9 and #8 address this

@byxorna byxorna self-assigned this Mar 6, 2019
@komapa
Copy link
Contributor

komapa commented Mar 6, 2019

I thought initContainers cannot be injected?

@byxorna
Copy link
Contributor Author

byxorna commented Mar 6, 2019

@komapa i am going to reinvestigate when i have time, and confirm. it would be great if we could; if not, ill have links here explaining exactly why they cant be patched into a pod.

@iwilltry42
Copy link
Contributor

@komapa I couldn't find any resource regarding your concerns. Only a wrong order of admission controllers might prevent injecting containers, e.g. PodSecurityPolicies (but containers in general, not only initContainers).
Anyways I can confirm for #8, that it works.
I tested it on Minikube and in our development cluster (though we don't have stuff like PodSecurityPolicies there).

@byxorna
Copy link
Contributor Author

byxorna commented Mar 8, 2019

@komapa @iwilltry42 I initially looked into this (way before this was opensourced) and I thought I found some reason I couldnt inject initContainers; I was clearly very mistaken :)

Thanks for sorting this out!

@byxorna
Copy link
Contributor Author

byxorna commented Mar 11, 2019

Closed via #8

@byxorna byxorna closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants