-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for initContainers #7
Comments
I thought initContainers cannot be injected? |
@komapa i am going to reinvestigate when i have time, and confirm. it would be great if we could; if not, ill have links here explaining exactly why they cant be patched into a pod. |
@komapa I couldn't find any resource regarding your concerns. Only a wrong order of admission controllers might prevent injecting containers, e.g. PodSecurityPolicies (but containers in general, not only initContainers). |
@komapa @iwilltry42 I initially looked into this (way before this was opensourced) and I thought I found some reason I couldnt inject initContainers; I was clearly very mistaken :) Thanks for sorting this out! |
Closed via #8 |
What's going on?
We should support initContainers in our injection configs
#9 and #8 address this
The text was updated successfully, but these errors were encountered: