[Feature] Add initContainer injector #9
Conversation
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
There was a problem hiding this comment.
awesome PR, thank you for this great PR, @zach-dunton-sf ! I would love to merge both #9 and #8, if we can integrate the features of both (annotation escaping, unit test refactors, etc)
| @@ -325,19 +325,19 @@ func mergeVolumeMounts(volumeMounts []corev1.VolumeMount, containers []corev1.Co | |||
|
|
|||
| func updateAnnotations(target map[string]string, added map[string]string) (patch []patchOperation) { | |||
| for key, value := range added { | |||
| keyEscaped := strings.Replace(key, "/", "~1", -1) | |||
There was a problem hiding this comment.
great catch! is this something you could add a unit test for, to assert this behavior is present?
|
Hi @zach-dunton-sf , would you mind if I integrate your changes regarding the annotations? |
|
I wouldn't mind at all. |
| @@ -0,0 +1,4 @@ | |||
| name: object2 | |||
| if c.Name != expectedName { | ||
| t.Fatalf("expected %s Name loaded from %s but got %s", expectedName, cfg, c.Name) | ||
| } | ||
| if len(c.Environment) != nExpectedEnvironmentVars { |
There was a problem hiding this comment.
Consider writing an expect function so we dont repeat the same if statement every time. expect(t, c.Environment, "envVars").hasSize(nExpectedEnvironmentVars) would be more readable.
|
Thanks for the contribution @zach-dunton-sf! Changes are in master, and you can use the docker image tagged Supplanted by #8 |
What and why?
I added support for injecting init containers. We are using it for injecting tools like New Relic in to our applications
There is also a small fix in the updateAnnotations function to escape '/' in annotation names so that the json patch works without overwriting existing pod annotations.
Testing Steps
make test)Reviewers
Required reviewers:
@byxornaRequest reviews from other people you want to review this PR in the "Reviewers" section on the right.