Stories: Scale to fill rendering + post-export overlays bug fixes #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordPress PR: wordpress-mobile/WordPress-iOS#16109
馃悶 Text disappears when using OpenGL +
scaleToFill
This was an alignment issue with text when using OpenGL +
scaleToFill
content mode.Demo
Notice the disappearing text after the confirm button is pressed.RPReplay_Final1615954257.mp4
RPReplay_Final1615954109.mp4
We now check the player's content mode before adjusting the size of the drawing & movable canvas views. These views are already properly sized to match the full size of the editor so we don't need to change them any further.
kanvas-ios/Classes/Editor/EditorView.swift
Lines 123 to 127 in 6803838
馃悶 Overlays disappear after exposing
Overlays were lost after exporting media. Because the Prepublishing sheet can be dismissed in WP-iOS, this causes text to be lost if the user goes back.
Demo
Notice how the text label disappears after dismissing the Prepublishing Sheet.Vid.mov
RPReplay_Final1615955075.mp4
We are reusing a single instance of
MovableViewCanvas
and it is not re-added to the current editor after exporting. It probably makes more sense to serialize the instance and create a new one but that change is more than we want to make after a code freeze.This addition reloads the editor after export is complete to ensure all archived data and views are present:
kanvas-ios/Classes/Editor/MultiEditor/MultiEditorViewController.swift
Lines 377 to 379 in 6803838