Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about sampleM in HairBCSDF #50

Open
Immocat opened this issue Mar 23, 2018 · 0 comments
Open

Question about sampleM in HairBCSDF #50

Immocat opened this issue Mar 23, 2018 · 0 comments

Comments

@Immocat
Copy link

Immocat commented Mar 23, 2018

Hi, Benedikt(@tunabrain)

Thanks for your rendering resources and papers at first, which I used and learned a lot from. I am implementing your Disney Hair/Fur BSDF(BCSDF), and I found some difference between your implementation in tungsten and pbrt's implementation when sampling the longitudinal M.

As mentioned in an open issue of pbrt, your implementation and the paper Importance Sampling for Physically-based Hair Fiber Models both firstly tilt the angle, and then sampling the M. However, pbrt's version is sampling M and then tilting. I think that your implementation and the paper's way are correct.

Please let me know if my opinion is wrong. Thank you very much for your attention.

Zejian Wang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant