Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev bootstrapping 2.0 #297

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Dev bootstrapping 2.0 #297

merged 4 commits into from
Mar 14, 2023

Conversation

Pro7ech
Copy link
Contributor

@Pro7ech Pro7ech commented Nov 17, 2022 •
edited
Loading

c.f. CHANGELOG.md

@Pro7ech Pro7ech mentioned this pull request Nov 17, 2022
Closed
@Pro7ech Pro7ech force-pushed the dev_bootstrapping_2.0 branch 3 times, most recently from 58c1a26 to 3b34321 Compare November 22, 2022 18:20
@Pro7ech Pro7ech force-pushed the dev_bootstrapping_2.0 branch 2 times, most recently from 5300f94 to 8b7b8af Compare December 7, 2022 16:29
@Pro7ech Pro7ech self-assigned this Dec 8, 2022
@Pro7ech Pro7ech added the enhancement New feature or request label Dec 8, 2022
@Pro7ech Pro7ech force-pushed the dev_bootstrapping_2.0 branch 2 times, most recently from a16cc9b to 1098645 Compare January 5, 2023 15:02
@Pro7ech Pro7ech marked this pull request as ready for review January 5, 2023 15:03
@Pro7ech Pro7ech force-pushed the dev_bootstrapping_2.0 branch 4 times, most recently from c379231 to 50066d3 Compare January 11, 2023 10:58
@Pro7ech Pro7ech mentioned this pull request Jan 13, 2023
Closed
n-samar
n-samar reviewed Jan 17, 2023
View reviewed changes
Copy link

@n-samar n-samar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work and giving me an opportunity to comment!

I hope my comments do not seem harsh: my primary goal was to comment clearly and concisely.

The bootstrapping interface is much more convenient for me the way it is now. Thank you! Please see the code comments for details and suggestions.

Nikola

ckks/bootstrapping/bootstrapping.go Outdated Show resolved Hide resolved
ckks/bootstrapping/bootstrapping.go Outdated Show resolved Hide resolved
examples/ckks/bootstrapping/main.go Outdated Show resolved Hide resolved
ckks/bootstrapping/bootstrapping.go Show resolved Hide resolved
examples/ckks/bootstrapping/main.go Show resolved Hide resolved
ckks/params.go Show resolved Hide resolved
ckks/params.go Show resolved Hide resolved
ckks/bootstrapping/default_params.go Show resolved Hide resolved
ckks/bootstrapping/default_params.go Outdated Show resolved Hide resolved
@Pro7ech Pro7ech linked an issue Jan 17, 2023 that may be closed by this pull request
[dckks]: GetMinimumLevelForBootstrapping can output false negatives #335
Closed
@Pro7ech Pro7ech force-pushed the dev_bootstrapping_2.0 branch 3 times, most recently from c94cab7 to e7e89f8 Compare January 20, 2023 10:22
@Pro7ech Pro7ech force-pushed the dev_bootstrapping_2.0 branch 2 times, most recently from 71b27b1 to f1ae13b Compare February 22, 2023 15:16
ChristianMct
ChristianMct reviewed Mar 2, 2023
View reviewed changes
ckks/advanced/homomorphic_encoding.go Outdated Show resolved Hide resolved
ckks/advanced/homomorphic_encoding.go Outdated Show resolved Hide resolved
ckks/advanced/homomorphic_mod.go Outdated Show resolved Hide resolved
ckks/advanced/homomorphic_mod.go Outdated Show resolved Hide resolved
ckks/advanced/homomorphic_mod.go Outdated Show resolved Hide resolved
ckks/bootstrapping/bootstrapping.go Outdated Show resolved Hide resolved
ckks/bootstrapping/bootstrapping.go Show resolved Hide resolved
ckks/bootstrapping/dummy_bootstrapping.go Outdated Show resolved Hide resolved
ckks/bootstrapping/dummy_bootstrapping.go Outdated Show resolved Hide resolved
ckks/bootstrapping/parameters.go Outdated Show resolved Hide resolved
ChristianMct
ChristianMct suggested changes Mar 3, 2023
View reviewed changes
ckks/bootstrapping/parameters.go Outdated Show resolved Hide resolved
dckks/utils.go Outdated Show resolved Hide resolved
examples/rgsw/main.go Show resolved Hide resolved
ring/basis_extension.go Show resolved Hide resolved
rlwe/bootstrapping.go Outdated Show resolved Hide resolved
rlwe/bootstrapping.go Outdated Show resolved Hide resolved
rlwe/params.go Outdated Show resolved Hide resolved
rlwe/params.go Outdated Show resolved Hide resolved
examples/ckks/bootstrapping/main.go Outdated Show resolved Hide resolved
ckks/bootstrapping/parameters.go Outdated Show resolved Hide resolved
ChristianMct
ChristianMct reviewed Mar 7, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ckks/bootstrapping/parameters_literal.go Show resolved Hide resolved
ckks/bootstrapping/parameters_literal.go Show resolved Hide resolved
ckks/bootstrapping/utils.go Outdated Show resolved Hide resolved
ckks/bootstrapping/utils.go Outdated Show resolved Hide resolved
ckks/bootstrapping/simple_bootstrapper.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Pro7ech
[ckks] bootstrapping improvements
79faa11 
rebased on #306



[ckks/advanced]: improved homomorphic encoding and tests


updated CHANGELOG.md


godoc and changelog update


[rlwe]: upgraded SwitchKeys for ring degree switching


review changes


[rlwe]: scale checks that float64 values are valid


updated CHANGELOG.md


[rlwe]: scale checks that big.Float aren't inf


typos


issue #335


[ckks/bootstrapping]: improved godoc and panic informations


[ckks/advanced]: matrices is now a public field of EncodingMatrix


[ckks/advanced]: small improvement


[ring]: all ModDown now do rounding, which reduces the variance error from ~4/12 to 1/12


[ring]: fixed ModDownQPToP test


[ckks]: added some public API to enable manual encoding of plaintexts


[ring]: ModUp now always centers the values


[ring]: Decompose now centers coefficients


[ckks/advanced]: fixed scaling in CoeffsToSlots matrix


rebased on main


[ckks][bootstrapping]: added ParametersLiteral marshalling
@Pro7ech
review changes
ce48cc9
@Pro7ech
updated CHANGELOG.md
51334e6
romainbou
romainbou approved these changes Mar 14, 2023
View reviewed changes
ckks/bootstrapping/bootstrapper.go Show resolved Hide resolved
ckks/bootstrapping/bootstrapping.go Show resolved Hide resolved
@Pro7ech Pro7ech merged commit 5b70714 into master Mar 14, 2023
@Pro7ech Pro7ech deleted the dev_bootstrapping_2.0 branch March 14, 2023 18:47
@Pro7ech Pro7ech added this to the v4.1.2 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-samar n-samar n-samar left review comments

@romainbou romainbou romainbou approved these changes

@ChristianMct ChristianMct ChristianMct approved these changes

@jrtroncoso jrtroncoso Awaiting requested review from jrtroncoso

Assignees

@Pro7ech Pro7ech

Labels
enhancement New feature or request
Projects
None yet
Milestone
v5
Development

Successfully merging this pull request may close these issues.

[dckks]: GetMinimumLevelForBootstrapping can output false negatives
4 participants
@Pro7ech @romainbou @ChristianMct @n-samar