ensure if max bigger than fn.toString().length

tunnckoCore · Mar 18, 2016 · e2cd9a3 · e2cd9a3
1 parent 506b3dd
commit e2cd9a3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -48,6 +48,9 @@ module.exports = function functionArguments (fn, max) {
   if (fnStr[0] !== '(' && arrow) {
     fnStr = 'function (' + fnStr.slice(0, arrow) + ')' + fnStr.slice(arrow)
   }
+  if (max > fnStr.length) {
+    max = fnStr.length
+  }
 
   var match = fnStr.slice(0, Number(max) || 100).match(/.*\(([^\)]*)\)/)
   return match ? require('arr-map')(match[1].split(','), function (param) {

diff --git a/test.js b/test.js
@@ -49,3 +49,10 @@ test('should get array with arguments names from regular function', function ()
   test.deepEqual(fnArgs(function * named (a, b, c) {}), ['a', 'b', 'c'])
 })
 
+test('should fail if `max` is bigger than fn.toString().length', function (done) {
+  function fixture (a, b) {
+    return [a, b]
+  }
+  test.deepEqual(fnArgs(fixture, 5555), ['a', 'b'])
+  done()
+})