Convert middleware once instead of doing it during routing #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yea, good point. Thanks! Next time, please use commit convention message. |
Sorry, i think i missed it... where can i find guideline you use for commit messages? |
|
Hm. My fault. I just realized that I didn't update the README to my new style. Can be found here for now https://github.com/tunnckoCore/resolve-plugins-sync#contributing and a i'll just update it here :) Just use |
tunnckoCore
pushed a commit
that referenced
this pull request
Jan 20, 2017
…nt rule introduced in #14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if there is reasoning for that...
But as of now alignment of different kinds of middlewares is done upon routing.
I believe it might be fairly ineffective to do it all the time, especially if number of middlewares is high.
Since route can be created only at
.createRoutemethod i moved it there.But i'm not sure if user is allowed to modify middlewares of route.
If it is allowed then, i suppose conversion is required at routing time, still it is fairly bad from my point of view.
Tests are passed locally.