Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index.js): fix path resolving for prefixed urls #2

Merged
merged 1 commit into from Jul 7, 2017
Merged

fix(index.js): fix path resolving for prefixed urls #2

merged 1 commit into from Jul 7, 2017

Conversation

artptr
Copy link
Contributor

@artptr artptr commented Jan 29, 2017

There was an incorrect path resolution in case of mapping of a serving directory to a prefixed url.

The reason is the path.resolve() function doesn't join its arguments. And in case of prefixed url, the fp parameter contains a leading slash.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8990013 on artptr:fix-path-resolving into c9fec80 on tunnckoCore:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 29, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8990013 on artptr:fix-path-resolving into c9fec80 on tunnckoCore:master.

@tunnckoCore
Copy link
Owner

Hmm. Strange. Good catch. I hate these filepath shits in node.

I'll merge when i get a bit more time, thanks 🎉

@tunnckoCore tunnckoCore merged commit fa2a076 into tunnckoCore:master Jul 7, 2017
@tunnckoCore
Copy link
Owner

@artptr thanks and sorry for the delay!

@tunnckoCore tunnckoCore mentioned this pull request Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants