Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #9 #10

Merged
merged 1 commit into from Feb 12, 2017
Merged

Fixed #9 #10

merged 1 commit into from Feb 12, 2017

Conversation

yuezk
Copy link
Contributor

@yuezk yuezk commented Feb 1, 2016

It should accept extra values in obj

It should accept extra values in `obj`
@bcorob bcorob mentioned this pull request Feb 11, 2017
Copy link

@bcorob bcorob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to address issue #9 and allows optional parameters to be specified.

@tunnckoCore
Copy link
Owner

@yuezk thanks! just didn't notice that PR, sorry mate!

@bcorob thanks for the review and bump in the #9 !

@tunnckoCore tunnckoCore merged commit 47f9a77 into tunnckoCore:master Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants