Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The FrameLayout overlaps other views #12

Closed
AlexHuicu opened this issue Sep 11, 2017 · 5 comments
Closed

The FrameLayout overlaps other views #12

AlexHuicu opened this issue Sep 11, 2017 · 5 comments

Comments

@AlexHuicu
Copy link

AlexHuicu commented Sep 11, 2017 •
edited
Loading

Steps to reproduce:

First way
1.Swipe the item:
screenshot_20170911-164749
2.Open a simple alert dialog:
screenshot_20170911-164809

Second way
1.Swipe the ListView:
screenshot_20170911-164839
2.Open a simple alert dialog:
screenshot_20170911-164844

The same behaviour occurs when you open a new activity and press back.
@AlexHuicu
Copy link
Author

Edit:
It happens when tapping on the button, and not beacuse of the Dialog

@Tunous
Copy link
Owner

Tunous commented Sep 11, 2017

Potential duplicate of #9

Setting app:sav_alwaysDrawBackground="true" could work as a workaround. (You might have to give your container views a background after that)

I wasn't yet able to reproduce the original issue. But I'll try to fix it again with this new information. Thank you for details :D

@AlexHuicu
Copy link
Author

AlexHuicu commented Sep 11, 2017 •
edited
Loading

I can't find the 'app:sav_alwaysDrawBackground' property. My root view is currently RelativeLayout. I will try to use a CoordinatorLayout and see if the problem is solved

@Tunous
Copy link
Owner

Tunous commented Sep 11, 2017

It's applied to SwipeActionView. Like here: https://github.com/Tunous/SwipeActionView/blob/master/sample/src/main/res/layout/activity_main.xml#L93

@AlexHuicu
Copy link
Author

That is a great hint :D

@Tunous Tunous mentioned this issue Sep 28, 2017
Closed
Tunous added a commit that referenced this issue Nov 12, 2018
@Tunous
Always draw background
4224061 
The code used to avoid drawing background relied on clipping canvas with REPLACE region operation which no longer works as of API 28. Because of that I decided to get rid of this behavior and instead always draw the background.

WARNING: This is a breaking change which might require users of the library to give container views custom backgrounds in their code to avoid transparency issues.

Closes #9, #12
@Tunous Tunous closed this as completed Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tunous @AlexHuicu