Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose drag resistance from initial position outside view #25

Closed
teal77 opened this issue Jul 1, 2020 · 3 comments · Fixed by #26
Closed

Expose drag resistance from initial position outside view #25

teal77 opened this issue Jul 1, 2020 · 3 comments · Fixed by #26
Labels
enhancement
Milestone
1.3.1

Comments

@teal77
Copy link
Contributor

teal77 commented Jul 1, 2020

Hey thanks for the library.

I have a usecase where swipe action is non destructive. ie It results in an archival rather than deletion.

Having the resistance to drag is not really necessary for me and I would like to configure the view in such a way that it skips the resistance calculation. (here?)

Can you please provide an API for this? Thanks.
@Tunous
Copy link
Owner

Tunous commented Jul 1, 2020

Yes, that looks to be the correct place. Would you be willing to make a pull request for that? Ideally we could allow library users to choose resistance of their preference.

@teal77
Copy link
Contributor Author

teal77 commented Jul 1, 2020

Sure. Do you have a preferred name for the property? Is dragResistance good enough?

@Tunous
Copy link
Owner

Tunous commented Jul 1, 2020

Sounds good.

teal77 added a commit to teal77/SwipeActionView that referenced this issue Jul 1, 2020
@teal77
Add a dragResistance property to SwipeActionView
bcf5fa9 
Replaces constant 3 with a property dragResistance when calculating
the resistance to drag in a drag event.
A validation is added in the setter to make sure the propety is
set to 1 or greater.

Fix Tunous#25
@teal77 teal77 mentioned this issue Jul 1, 2020
Merged
@Tunous Tunous closed this as completed in #26 Jul 1, 2020
Tunous pushed a commit that referenced this issue Jul 1, 2020
@teal77
Add a dragResistance property to SwipeActionView (#26)
6813459 
Replaces constant 3 with a property dragResistance when calculating
the resistance to drag in a drag event.
A validation is added in the setter to make sure the propety is
set to 1 or greater.

Fix #25
@Tunous Tunous added this to the 1.3.1 milestone Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.3.1
Development

Successfully merging a pull request may close this issue.

Add a dragResistance property to SwipeActionView teal77/SwipeActionView
2 participants
@Tunous @teal77