Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mdxへ移行 #79

Merged
merged 7 commits into from
Oct 15, 2021
Merged

refactor: mdxへ移行 #79

merged 7 commits into from
Oct 15, 2021

Conversation

knokmki612
Copy link
Member

#78 への対応

@knokmki612 knokmki612 marked this pull request as ready for review October 8, 2021 03:08
Copy link
Contributor

@Hidetaro7 Hidetaro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的に期待通り表示されている
ブラウザの下記のWarningが表示されている

react-dom.development.js:88 Warning: Invalid DOM property `class`. Did you mean `className`?
    in i (created by MDXCreateElement)
    in MDXCreateElement (created by MDXContent)
    in wrapper (created by MDXCreateElement)
    in MDXCreateElement (created by MDXContent)
    in MDXContent (created by page)
    in AddContext (created by page)
    in page
    in div (created by Context.Consumer)
    in Styled(div) (created by DocsContainer)
    in div (created by Context.Consumer)
    in Styled(div) (created by DocsContainer)
    in MDXProvider (created by DocsContainer)
    in ThemeProvider (created by DocsContainer)
    in SourceContainer (created by DocsContainer)
    in DocsContainer

@knokmki612
Copy link
Member Author

ブラウザの下記のWarningが表示されている

どのような操作をしたときに表示されるのか教えていただけますか?(どこをクリックした、など)

私の手元では、mdxに移行した各ストーリーのCanvas表示をおこなっている段階では、warningを含めブラウザーのコンソールでは表示されていないです

@Hidetaro7
Copy link
Contributor

ブラウザの下記のWarningが表示されている

再現しなくなった、特に何かを押したという記憶がないので、経緯が不明

@knokmki612
Copy link
Member Author

issueとして残しておきました

Copy link
Contributor

@Hidetaro7 Hidetaro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@knokmki612 knokmki612 merged commit 3b4b973 into develop Oct 15, 2021
@knokmki612 knokmki612 deleted the feat-migrate-to-mdx branch October 15, 2021 06:04
@knokmki612 knokmki612 mentioned this pull request Nov 11, 2021
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants