Count link redirects #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
requested review from
janusz-chludzinski-zz and
TobKed
as code owners
janusz-chludzinski-zz
approved these changes
Aug 28, 2020
pkg/app/router.go
Outdated
| @@ -92,6 +93,15 @@ func redirectHandler(w http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| // To avoid redirect loop | |||
| if link.URL == link.ID { | |||
| http.Error(w, "Link id must be different than url", http.StatusBadRequest) | |||
There was a problem hiding this comment.
Link id is, IMHO, bit confusing. As a user I would probably confused what this ID is. As far as I understand now id is url part provided by the user? If so, I'd recommend changing it to something like value or something similar :)
There was a problem hiding this comment.
Good suggestion! I've renamed it and added some comments to structs
janusz-chludzinski-zz
approved these changes
Aug 28, 2020
| @@ -92,6 +92,15 @@ func redirectHandler(w http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| // To avoid redirect loop | |||
| if link.URL == link.Value { | |||
| http.Error(w, "Alternative url value must be different than the url", http.StatusBadRequest) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2