Improve api #5
Improve api #5
Conversation
|
@JonathanDDuncan you can follow this if you're interesting in further updates. |
|
Unfortunately tests should fail here due to |
- Make travis really compolime examples - DRY examples
examples/subscriptions/Main.elm
Outdated
| Glue.subscriptions moves sub model | ||
| else | ||
| -- without this even clicks are bypassed | ||
| sub model |
There was a problem hiding this comment.
Ok, this is really ugly with simple.
| |> Glue.subscriptionsWhen .subModuleSubOn subModule | ||
| ``` | ||
| -} | ||
| subscriptionsWhen : (model -> Bool) -> Glue model subModel msg subMsg -> (model -> Sub msg) -> (model -> Sub msg) |
There was a problem hiding this comment.
well not sure if this is good enough...
|
will continue by #6 |
|
@turboMaCk I decided to work on my own fork which has changed a lot from what I started with. It will give you an idea what I thought would be fun to write, which it has. Now I'm finished and may not touch it again for a while. But you are welcome to take a look and steal any ideas you feel like. |
|
Pls don't use big letters in package name. elm-package has issues with that. Also be aware that some people might have issue with that OOP like api: |
|
Anyway I also see that you have it wrong. You're exposing module which isn't even there: https://github.com/JonathanDDuncan/ElmMiniApps/blob/master/elm-package.json#L10 |
|
@turboMaCk I decided last week to revisit my code and improve it a bit. Basically now I am creating records that contains the references to the miniapps to be able to do everything and the code is just functions based on these. There are only two configurators: configure and configurebubbuling and both use the same API. One thing that mine has different than Glue is that I can create a MiniAppsSimpleConfiguration of all the miniapps I want to expose with minimal changes to the main application itself and can add them anywhere to the view with MiniApps.viewsubapp miniapps miniapp model. Instead of TEA I decided to go with miniapp. Also I wanted to suggest that if the examples had something more substantial of a mini-app like a signin form instead of the counters it might not be as offensive to some of the early adopters of Elm. Wish you the best Jonathan |
This is continuation of #4. Goals are:
update documentationreview once again