Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back YAML configuration option #20

Merged
merged 6 commits into from Apr 15, 2020
Merged

Bring back YAML configuration option #20

merged 6 commits into from Apr 15, 2020

Conversation

turbokongen
Copy link
Owner

No description provided.

@Hellowlol
Copy link
Contributor

IMO setting up using yaml should never been removed. Im still pretty sure the error is in _check and update method. I can check and make a PR for this.

@turbokongen
Copy link
Owner Author

IMO setting up using yaml should never been removed. Im still pretty sure the error is in _check and update method. I can check and make a PR for this.

Sure, no problem. Let's add it back in.

@turbokongen turbokongen changed the title Sometimes sensors got missing in setup Bring back YAML configuration option Apr 7, 2020
@turbokongen
Copy link
Owner Author

@Hellowlol
Can you test this?
I've tested it on my machines, and works as expected.

@Hellowlol
Copy link
Contributor

Will do. Btw i think you should change the name in hacs.json i couldnt figure out why i didnt find the integration when i tried to set it up.

@Hellowlol Hellowlol mentioned this pull request Apr 8, 2020
5 tasks
@turbokongen turbokongen added the bug Something isn't working label Apr 9, 2020
@turbokongen turbokongen force-pushed the missing_sensors branch 2 times, most recently from a6351cf to 6e0bcf9 Compare April 10, 2020 07:32
@turbokongen
Copy link
Owner Author

@Hellowlol did this work to your expectations?

@Hellowlol
Copy link
Contributor

I havn't got around to test it. Busy with some other HA stuff. Ill test it later to day.

@turbokongen turbokongen merged commit 8b92e49 into master Apr 15, 2020
@turbokongen turbokongen deleted the missing_sensors branch February 18, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants