Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows, WASI targets support #7

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Windows, WASI targets support #7

merged 5 commits into from
Jan 26, 2022

Conversation

vshymanskyy
Copy link
Contributor

@vshymanskyy vshymanskyy commented Jan 24, 2022 •
edited

Following-up the idea in #1 (comment)

  • Allow disabling pthreads
  • Initial Windows target support (no parallel mode + getopt impl)
  • Initial WASI target support
  • Skip creating empty files in parallel mode

@vshymanskyy
- Allow disabling pthreads
3d8730b 
- Initial Windows support (no parallel mode + getopt impl)
- Skip creating empty files in parallel mode
@vshymanskyy
Fix CI?
1e008fe
@vshymanskyy
Fix warnings
8df2649
@vshymanskyy
Copy link
Contributor Author

@turbolent please review

@vshymanskyy vshymanskyy changed the title Windows support Windows, WASI targets support Jan 24, 2022
@vshymanskyy
Copy link
Contributor Author

vshymanskyy commented Jan 24, 2022 •
edited

You can now build a WASI-powered w2c2.wasm, using wasienv:

wasimake make

@vshymanskyy vshymanskyy mentioned this pull request Jan 25, 2022
Open
turbolent
turbolent approved these changes Jan 26, 2022
View reviewed changes
Copy link
Owner

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

c.c Show resolved Hide resolved
c.c Show resolved Hide resolved
getopt_impl.h Show resolved Hide resolved
@vshymanskyy @turbolent
Update getopt_impl.h
9dd8d1c 
Co-authored-by: Bastian Müller <bastian@turbolent.com>
@vshymanskyy
Copy link
Contributor Author

@turbolent should be ready for merge

@turbolent
Copy link
Owner

Great, thank you again!

@turbolent turbolent merged commit 9c83247 into turbolent:main Jan 26, 2022
@turbolent turbolent added the enhancement New feature or request label Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vshymanskyy @turbolent