Skip to content
This repository has been archived by the owner on Jul 28, 2018. It is now read-only.
This repository has been archived by the owner on Jul 28, 2018. It is now read-only.

Feature request - more control over content replacement #288

Open
andriytyurnikov opened this issue Oct 15, 2013 · 2 comments
Open

Feature request - more control over content replacement #288

andriytyurnikov opened this issue Oct 15, 2013 · 2 comments

Comments

@andriytyurnikov
Copy link

Guys, we will definitely need more control over page transition process, to overuse animations)))

Here is trivial proof of concept implementation https://github.com/andriytyurnikov/turbolinks/tree/better_changePage

And example http://turbolinks-transitions.herokuapp.com/ )))

@reed
Copy link
Collaborator

reed commented Oct 18, 2013

This is cool, but it probably won't work alongside the upcoming cached transition feature (#286) since the page will be changing twice.

@andriytyurnikov
Copy link
Author

Wow. You are right, and page will be changing twice But a) cached transition may be turned off,
and b) in fact instead of having one function (as in my example)
Turbolinks.defaultBodyUpdater
we could have 2

Turbolinks.cacheBodyUpdater
Turbolinks.networkBodyUpdater

or all 3 of them :)
Any thoughts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants