-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework to support exporters from configuration file #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Looks like there will be a good amount of integration effort on my part though haha. It would be good to increase our test coverage at some point though.
used: '1000.0*rate(istio_turbo_pod_latency_time_ms_sum{response_code="200"}[3m])/rate(istio_turbo_pod_latency_time_ms_count{response_code="200"}[3m]) >= 0' | ||
TRANSACTION: | ||
queries: | ||
used: 'rate(istio_turbo_pod_request_count{response_code="200"}[3m]) > 0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe document somewhere that the "used" query is mandatory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
TRANSACTION: | ||
queries: | ||
used: 'rate(istio_turbo_pod_request_count{response_code="200"}[3m]) > 0' | ||
attributes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe document that every attributes section must include exactly one identifier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
Thanks for the review @dblinn. As a general comment, it is in my plan to add complete documentation and test cases in separate PRs. |
- Simplify the logic to detect attributes with multiple identifiers
This pull request is the initial implementation of a general framework to support Prometheus exporters from configuration file. The
appMetric
component will now constructEntityMetric
based on the following information defined in the configuration:The following is an example of the configuration for
mysql
exporter:The following is the sample output:
TODO:
This pull request also adds turbo custom metrics definition for istio 1.4.