Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue for supporting multi-platform build #99

Merged
merged 1 commit into from
May 23, 2023

Conversation

kevinwangcn
Copy link

Intent

To fix the problem that the prometurbo binary in the ppc64le/arm64/s390x image is wrongly built

Background

https://vmturbo.atlassian.net/browse/OM-100670

Implementation

Pass the GOOS and GOARCH` arguments to the build command

Test

root@dawning1:~# uname -a
Linux dawning1.fyre.ibm.com 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:07 UTC 2023 ppc64le ppc64le ppc64le GNU/Linux
root@dawning1:~# docker pull kevin0204/prometurbo:8.8.6-LAST
8.8.6-LAST: Pulling from kevin0204/prometurbo
a3ece89037f7: Pull complete 
7968d67930b1: Pull complete 
d0c89ff1051f: Pull complete 
25faa6ffa235: Pull complete 
e0256f99bfab: Pull complete 
c0d62a0bfbb6: Pull complete 
d8719c7a336e: Pull complete 
4f4fb700ef54: Pull complete 
Digest: sha256:618aaec2a3371dc0a28565904ff34a9c5895c790662d0fd4493a8157355594eb
Status: Downloaded newer image for kevin0204/prometurbo:8.8.6-LAST
docker.io/kevin0204/prometurbo:8.8.6-LAST
root@dawning1:~# docker run -it --entrypoint sh  kevin0204/prometurbo:8.8.6-LAST
sh-4.4$ exec /opt/turbonomic/bin/prometurbo 
I0416 23:02:29.381889       1 prometurbo.go:80] Running prometurbo GIT_COMMIT: 
I0416 23:02:29.384116       1 provider.go:37] Metrics config file /etc/prometurbo/prometheus.config does not exist.
F0416 23:02:29.384140       1 prometurbo.go:122] Fatal error: failed to get in-cluster config: unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined.

@kevinwangcn kevinwangcn merged commit 5dac259 into turbonomic:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants