Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add list-get-hydrate #185

Merged
merged 8 commits into from
Mar 25, 2024
Merged

add list-get-hydrate #185

merged 8 commits into from
Mar 25, 2024

Conversation

judell
Copy link
Contributor

@judell judell commented Mar 21, 2024

No description provided.

@judell judell requested a review from johnsmyth March 21, 2024 19:31
Copy link
Contributor

@johnsmyth johnsmyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@judell I'm going to merge this for now, but if you have further changes or additions we should discuss them first. This page has become quite long and we should probably break it up into multiple pages. Also, this started out with a single set of related examples from a single plugin but now the examples are all over the place; we should try to use the same plugin for the examples where possible as it feels a bit jarring to change the context a lot.

@johnsmyth johnsmyth merged commit 42ecb80 into main Mar 25, 2024
1 check passed
@johnsmyth johnsmyth deleted the list-get-hydrate branch March 25, 2024 12:42
@judell
Copy link
Contributor Author

judell commented Mar 25, 2024

we should probably break it up into multiple pages

Absolutely.

try to use the same plugin for the examples where possible

OK. There some cases where it's necessary to diversify, in order to show a feature that happens to only be illustrated in one plugin in or other, but yeah, there's probably more than the necessary amount of diversity now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants