Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new controls closes #46 #47

Merged
merged 5 commits into from Nov 30, 2023
Merged

Add new controls closes #46 #47

merged 5 commits into from Nov 30, 2023

Conversation

khushboo9024
Copy link
Contributor

Checklist

  • Issue(s) linked

@khushboo9024 khushboo9024 self-assigned this Nov 24, 2023
rajlearner17
rajlearner17 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@rajlearner17 rajlearner17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

madhushreeray30
madhushreeray30 reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@madhushreeray30 madhushreeray30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khushboo9024 please take a look at the comments, thanks!

controls/appservice.sp Outdated Show resolved Hide resolved
controls/appservice.sp Outdated Show resolved Hide resolved
controls/appservice.sp Outdated Show resolved Hide resolved
controls/eventhub.sp Outdated Show resolved Hide resolved
controls/eventhub.sp Outdated Show resolved Hide resolved
query/eventhub.sp Outdated Show resolved Hide resolved
query/eventhub.sp Outdated Show resolved Hide resolved
query/eventhub.sp Outdated Show resolved Hide resolved
query/kubernetes.sp Outdated Show resolved Hide resolved
query/kubernetes.sp Outdated Show resolved Hide resolved
madhushreeray30
madhushreeray30 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@madhushreeray30 madhushreeray30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@madhushreeray30 madhushreeray30 merged commit 6f2b8b1 into release/v0.11 Nov 30, 2023
@madhushreeray30 madhushreeray30 deleted the issue-46 branch November 30, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajlearner17 rajlearner17 rajlearner17 approved these changes

@madhushreeray30 madhushreeray30 madhushreeray30 approved these changes

Assignees

@khushboo9024 khushboo9024

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khushboo9024 @rajlearner17 @madhushreeray30