Fixed Issue querying ACK table when no tags set on cluster Closes #425 #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ParthaI is it possible to use an inbuilt Transform function to check if the value of tags is null or not? |
|
@misraved, while we have the transform function |
misraved
reviewed
Jun 11, 2024
| @@ -504,6 +504,10 @@ func getCsKubernetesClusterARN(ctx context.Context, d *plugin.QueryData, h *plug | |||
| //// TRANSFORM FUNCTIONS | |||
|
|
|||
| func csKubernetesClusterAkaTagsToMap(_ context.Context, d *transform.TransformData) (interface{}, error) { | |||
| if d.Value == nil { | |||
There was a problem hiding this comment.
@ParthaI if we are already checking d.Value == nil then I don't think we need the check mentioned in lines https://github.com/turbot/steampipe-plugin-alicloud/pull/426/files#diff-01756e1a7a77698610d809a8875a0ab69232965568f82bf94296fa5560ad9ce1L508-L514.
misraved
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test logs
Logs
Example query results
Results