Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom endpoint url configuration. Closes #1050 #1053

Merged
merged 1 commit into from Jun 3, 2022
Merged

Allow custom endpoint url configuration. Closes #1050 #1053

merged 1 commit into from Jun 3, 2022

Conversation

srgg
Copy link
Contributor

@srgg srgg commented Jun 1, 2022 •
edited

Closes #1050.

Integration test logs

Logs 
Add passing integration test logs here

Example query results

Results 
Add example SQL query results here (please include the input queries as well)

@srgg srgg changed the title Add endpoint_url config arg to allow custom endpoint url configurat… Allow custom endpoint url configuration Jun 1, 2022
@srgg srgg changed the title Allow custom endpoint url configuration Allow custom endpoint url configuration. Closes #1050 Jun 1, 2022
@srgg srgg mentioned this pull request Jun 2, 2022
Closed
@srgg srgg force-pushed the issue_1050_endpoint_url_configguration branch from 5a57ea6 to 5bf1837 Compare June 2, 2022 23:34
@cbruno10 cbruno10 merged commit 54741bf into turbot:main Jun 3, 2022
@cbruno10
Copy link
Contributor

cbruno10 commented Jun 3, 2022

@srgg Thanks again for the contribution, we're excited for our plugin to now be compatible with local AWS services, LocalStack, and similar tools!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbruno10 cbruno10 cbruno10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Localstack (custom endpoint-url) support
2 participants
@srgg @cbruno10