Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capacity_reservation_specification column of aws_ec2_instance table to be of JSON type closes #1894 #1903

Merged
merged 1 commit into from Sep 12, 2023
Merged

Fix capacity_reservation_specification column of aws_ec2_instance table to be of JSON type closes #1894 #1903

merged 1 commit into from Sep 12, 2023

Conversation

misraved
Copy link
Contributor

@misraved misraved commented Sep 11, 2023 •
edited by madhushreeray30

Integration test logs

Logs 
Add passing integration test logs here

Example query results

Results 
> select instance_id, arn, capacity_reservation_specification from aws_ec2_instance
[
 {
  "arn": "arn:aws:ec2:us-east-1:111111111111:instance/i-061073b2b90b8a7da",
  "capacity_reservation_specification": {
   "CapacityReservationPreference": "",
   "CapacityReservationTarget": {
    "CapacityReservationId": "cr-022bb8c139a39f1d2",
    "CapacityReservationResourceGroupArn": null
   }
  },
  "instance_id": "i-061073b2b90b8a7da"
 }
]
>

@misraved misraved self-assigned this Sep 11, 2023
@misraved misraved changed the title Fix capacity_reservation_specification column of aws_ec2_instance table to be of JSOn type closes #1894 Fix capacity_reservation_specification column of aws_ec2_instance table to be of JSON type closes #1894 Sep 11, 2023
@misraved misraved marked this pull request as ready for review September 11, 2023 12:34
@misraved misraved linked an issue Sep 11, 2023 that may be closed by this pull request
Should the capacity_reservation_specification column in aws_ec2_instance table should be JSONB type? #1894
Closed
@cbruno10
Copy link
Contributor

@misraved Can you please include the query results in the PR description? Thanks!

@misraved misraved merged commit c6f0365 into main Sep 12, 2023
1 check passed
@misraved misraved deleted the fix-ec2-instance-capacity-reservation-column branch September 12, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhushreeray30 madhushreeray30 madhushreeray30 approved these changes

Assignees

@misraved misraved

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should the capacity_reservation_specification column in aws_ec2_instance table should be JSONB type?
3 participants
@misraved @cbruno10 @madhushreeray30