Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing parent to resourceGroup to remove duplicate network gateway entry. Closes #180 #181

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

Subhajit97
Copy link
Contributor

@Subhajit97 Subhajit97 commented Jul 14, 2021

Bug Fixes

  • Earlier network gateway resource has dependency on virtual network resource, hence table stores duplicate resources, whenever more than one virtual network resource is present in a resourceGroup.
    Currently, the dependency has been updated, to list the resource based on available resource group.

Earlier Response

> select name, id from azure_virtual_network_gateway;
+--------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------+
| name               | id                                                                                                                                                  |
+--------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------+
| test               | /subscriptions/********-****-****-****-************/resourceGroups/abcd-test1/providers/Microsoft.Network/virtualNetworkGateways/test               |
| express-route-test | /subscriptions/********-****-****-****-************/resourceGroups/abcd-test1/providers/Microsoft.Network/virtualNetworkGateways/express-route-test |
| test               | /subscriptions/********-****-****-****-************/resourceGroups/abcd-test1/providers/Microsoft.Network/virtualNetworkGateways/test               |
| express-route-test | /subscriptions/********-****-****-****-************/resourceGroups/abcd-test1/providers/Microsoft.Network/virtualNetworkGateways/express-route-test |
+--------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------+

Current Response

> select name, id from azure_virtual_network_gateway;
+--------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------+
| name               | id                                                                                                                                                  |
+--------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------+
| express-route-test | /subscriptions/********-****-****-****-************/resourceGroups/abcd-test1/providers/Microsoft.Network/virtualNetworkGateways/express-route-test |
| test               | /subscriptions/********-****-****-****-************/resourceGroups/abcd-test1/providers/Microsoft.Network/virtualNetworkGateways/test               |
+--------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------+

Integration test logs

Logs
N/A

Example query results

Results
N/A

@cbruno10 cbruno10 merged commit 83213b8 into main Jul 15, 2021
@cbruno10 cbruno10 deleted the issue-180 branch July 15, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same virtual network gateways getting upserted 2 times in the table azure_virtual_network_gateway.
2 participants