Add support to read resources from kubernetes manifests. Closes #128 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into parse-kube-manifest
…est is used to create the resource
…nfig is set to list both deployed and manifest resource
misraved
reviewed
May 22, 2023
| @@ -1,4 +1,4 @@ | |||
| # Table: kubernetes_{custom_resource_singular_name} | |||
| # Table: kubernetes\_{custom_resource_singular_name} | |||
There was a problem hiding this comment.
Suggested change
| # Table: kubernetes\_{custom_resource_singular_name} | |
| # Table: kubernetes_{custom_resource_singular_name} |
misraved
reviewed
May 22, 2023
Comment on lines
+126
to
+131
| kubernetesConfig := GetConfig(c) | ||
| filterCrds := kubernetesConfig.CustomResourceTables | ||
| if len(filterCrds) == 0 { | ||
| return nil, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Yes, @misraved, we need this code block to validate if a list of custom resource tables is set in the config before creating the client.
misraved
reviewed
May 22, 2023
Comment on lines
106
to
108
| // | ||
| // Check for deployed resources | ||
| // |
There was a problem hiding this comment.
Suggested change
| // | |
| // Check for deployed resources | |
| // | |
| // Check for deployed resources | |
misraved
reviewed
May 22, 2023
There was a problem hiding this comment.
@Subhajit97 please take a look at the minor review comments.
Also please make sure that we have tested the manifest changes against the filewatcher property.
misraved
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example query results
Results