Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to parse Helm charts #139

Merged
merged 71 commits into from
Jun 23, 2023
Merged

Conversation

Subhajit97
Copy link
Contributor

Example query results

Results
Add example SQL query results here (please include the input queries as well)

@Subhajit97 Subhajit97 self-assigned this Jun 6, 2023
@Subhajit97 Subhajit97 marked this pull request as ready for review June 7, 2023 16:13
@Subhajit97 Subhajit97 linked an issue Jun 7, 2023 that may be closed by this pull request
Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Subhajit97 Please see doc comments, thanks!

@@ -54,100 +60,35 @@ Download and install the latest Kubernetes plugin:
steampipe plugin install kubernetes
```

### Configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get Started

Install

Configuration

Include simplest example of using kube config with the default kube config file location and the default context (or if they need to specify one, use an example)

Additional configuration examples are included below and for a full list of configuration arguments, please see the default configuration file.

Run a Query

Show steampipe query, the query, results

Configuring Kubernetes Cluster Credentials

...

docs/index.md Outdated
@@ -16,6 +16,12 @@ og_image: "/images/plugins/turbot/kubernetes-social-graphic.png"

[Kubernetes](https://kubernetes.io) is an open-source system for automating deployment, scaling, and management of containerized applications.

## Overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Overview

@@ -199,21 +128,17 @@ connection "kubernetes_all" {
}
```

## Custom Resource Definitions
### Custom Resource Definitions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Custom Resource Definitions
### Custom resource definitions
### Custom Resource Definitions

When deciding between using title case or not, this one is confusing for me IMO

Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a high level, the changes look great and the doc changes seem appropriate. I'm approving but will leave the final review and merge up to @misraved

@misraved misraved merged commit 4d32bd4 into main Jun 23, 2023
1 check passed
@misraved misraved deleted the add-support-to-parse-helm-charts branch June 23, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to parse Helm charts and templates
3 participants