Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a field to the net_certificate table to specify a port #48

Closed
bdd4329 opened this issue Sep 12, 2022 · 9 comments · Fixed by #50
Closed

Add a field to the net_certificate table to specify a port #48

bdd4329 opened this issue Sep 12, 2022 · 9 comments · Fixed by #50
Assignees
Labels
enhancement New feature or request

Comments

@bdd4329
Copy link
Contributor

bdd4329 commented Sep 12, 2022

Is your feature request related to a problem? Please describe.
I would like to be able to monitor certificate expiration dates on other commonly used TLS ports such as 636, 8443, etc. Using an alternative product to monitor other ports means that I can't easily have a single dashboard for all of my certs if I want to use Steampipe.

Describe the solution you'd like
"port" should be added as a field to the net_certificate table, which would enable certificates on arbitrary ports to be monitored. I assume that it's not there right now so that it doesn't need to be specified for most cases.

Describe alternatives you've considered
Use an alternative product to monitor these ports.

Additional context
None

@bdd4329 bdd4329 added the enhancement New feature or request label Sep 12, 2022
@cbruno10 cbruno10 linked a pull request Sep 14, 2022 that will close this issue
@github-actions
Copy link

'This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Oct 12, 2022
@bdd4329
Copy link
Contributor Author

bdd4329 commented Oct 12, 2022

I can see that @cbruno10 added a PR for this issue (#50). Is there some reason why his PR hasn't been approved?

@e-gineer e-gineer removed the stale No recent activity has been detected on this issue/PR and it will be closed label Oct 13, 2022
@cbruno10
Copy link
Contributor

Hi @bdd4329 , for that PR, I had started work on it, but then had a thought that instead of just adding port, what if instead we added a new column that would take a full address, including the port (similar to other tables in this plugin), and deprecate the current domain column.

I was assessing the impact of this change on the table + mods that use, like the Net Insights Mod, and then unfortunately got distracted with some other priorities.

I'll take another look at the PR and its impact again this week, but in the meantime @bdd4329 , if this is a blocker for you, feel free to locally compile the add-certificate-port branch and see if the new address column helps with your requirements.

@bdd4329
Copy link
Contributor Author

bdd4329 commented Oct 17, 2022

@cbruno10. I don't have any problem with waiting another week. I responded because I saw that the "stale" label had been placed on the issue, and I didn't want it to be closed.

@github-actions
Copy link

'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Dec 16, 2022
@cbruno10 cbruno10 removed the stale No recent activity has been detected on this issue/PR and it will be closed label Dec 19, 2022
@github-actions
Copy link

'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Feb 17, 2023
@cbruno10 cbruno10 removed the stale No recent activity has been detected on this issue/PR and it will be closed label Feb 21, 2023
@github-actions
Copy link

'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Apr 22, 2023
@cbruno10 cbruno10 removed the stale No recent activity has been detected on this issue/PR and it will be closed label Apr 25, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Jun 24, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 90 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2023
@cbruno10 cbruno10 reopened this Jul 26, 2023
@github-actions github-actions bot removed the stale No recent activity has been detected on this issue/PR and it will be closed label Jul 26, 2023
cbruno10 added a commit that referenced this issue Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants