-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snowflake session, schemata, login_history and account_parameter table; Add common columns account
and region
to all tables; Add warehouse
connection config argument
#2
Conversation
…nto add_new_tables
account
and region
to all tables; Add warehouse
connection config argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LalitTurbot Please see comments, thanks!
snowflake/connect.go
Outdated
Database: database, | ||
Schema: schema, | ||
Warehouse: warehouse, | ||
Application: "STEAMPIPE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this shouldn't be STEAMPIPE
for all users? What is the Application
used for? Do we need a config arg for it?
CHANGELOG.md
Outdated
_Enhancements_ | ||
|
||
- Added `account` and `region` metadata column to all existing tables. | ||
- Changed the column type of `ext_authn_duo` column from string to bool in `snowflake_user` table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be under the _Bug fixes_
section instead, assuming it was always meant to be a bool instead of string type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snowflake stores ext_authn_duo
as string true
or false
. Hence changed column type to Bool from String for easier handling in queries.
@@ -82,6 +82,16 @@ func connect(ctx context.Context, d *plugin.QueryData) (*sql.DB, error) { | |||
if config.OAuthAccessToken != nil { | |||
oauthAccessToken = *config.OAuthAccessToken | |||
} | |||
// TODO - Required to query general tables through steampipe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we're planning on adding soon? What's the result of us not having arg support for these yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, If someone requests to query snowflake tables using steampipe
Example query results
Results