Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed table terraform_resource column arguments not showing field named type Closes #98 #99

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented May 31, 2024

Integration test logs

Logs
N/A

Example query results

Results
> select name, type, jsonb_pretty(arguments) as arguments from terraform_resource
+-----------------------------------------+-----------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------+
| name                                    | type                  | arguments                                                                                                                                                     |
+-----------------------------------------+-----------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------+
| aws_iam_regional_access_analyzer_source | turbot_policy_setting | {                                                                                                                                                             |
|                                         |                       |     "note": "AWS CIS v3.0.0 - Controls: 1.20",                                                                                                                |
|                                         |                       |     "type": "tmod:@turbot/aws#/policy/types/regionStackSource",                                                                                               |
|                                         |                       |     "value": "resource \"aws_accessanalyzer_analyzer\" \"cis_access_analyzer\" {\n  analyzer_name = \"access_analyzer\"\n  type          = \"ACCOUNT\"\n}\n", |
|                                         |                       |     "resource": "${turbot_smart_folder.aws_cis_v300_s1_iam.id}"                                                                                               |
|                                         |                       | }                                                                                                                                                             |
+-----------------------------------------+-----------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------+

@ParthaI ParthaI requested a review from misraved May 31, 2024 07:06
@ParthaI ParthaI self-assigned this May 31, 2024
@ParthaI ParthaI linked an issue May 31, 2024 that may be closed by this pull request
@karanpopat
Copy link

Thanks for the fix @ParthaI
Looks good

> select name,jsonb_pretty(arguments),type as arguments from terraform_resource where name = 'aws_iam_regional_access_analyzer_source'
+-----------------------------------------+--------------------------------------------------------------------------------------------------------->
| name                                    | jsonb_pretty                                                                                            >
+-----------------------------------------+--------------------------------------------------------------------------------------------------------->
| aws_iam_regional_access_analyzer_source | {                                                                                                       >
|                                         |     "note": "AWS CIS v3.0.0 - Controls: 1.20",                                                          >
|                                         |     "type": "tmod:@turbot/aws#/policy/types/regionStackSource",                                         >
|                                         |     "value": "resource \"aws_accessanalyzer_analyzer\" \"cis_access_analyzer\" {\n  analyzer_name = \"ac>
|                                         |     "resource": "${turbot_smart_folder.aws_cis_v300_s1_iam.id}"                                         >
|                                         | }                                                                                                       >
+-----------------------------------------+--------------------------------------------------------------------------------------------------------->

@misraved misraved merged commit 847ed4e into main Jun 21, 2024
1 check passed
@misraved misraved deleted the issue-98 branch June 21, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table terraform_resource column arguments not showing field named type
3 participants