Adds support for starting dashboard server with service start
#1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Outputs: |
kaidaguerre
requested changes
Feb 21, 2022
| if viper.GetBool(constants.ArgDashboardClient) { | ||
| err = dashboardserver.OpenBrowser(fmt.Sprintf("http://localhost:%d", serverPort)) | ||
| if err != nil { | ||
| log.Println("[TRACE] dashboard server started but failed to start client", err) |
There was a problem hiding this comment.
should this be a warning not trace? or should the status message indicate this
There was a problem hiding this comment.
This is an inconvenience rather than an ERROR or WARNING. That's why I put it on TRACE.
We still get the port in the output.
|
|
||
| var dashboardState *dashboardserver.DashboardServiceState | ||
| if viper.GetBool(constants.ArgDashboard) { | ||
| serverPort := dashboardserver.ListenPort(viper.GetInt(constants.ArgDashboardPort)) |
There was a problem hiding this comment.
put into startDashBoardServer() function
| @@ -279,6 +320,8 @@ func runServiceRestartCmd(cmd *cobra.Command, args []string) { | |||
| fmt.Println("Steampipe service is not running.") | |||
| return | |||
| } | |||
| currentDashboardState, err := dashboardserver.GetDashboardServiceState() | |||
There was a problem hiding this comment.
comments describing our approach to restarting dashboard server
cmd/service.go
Outdated
| } else { | ||
| dbState, err = db_local.GetState() | ||
| if err != nil { | ||
| { // Code fold |
There was a problem hiding this comment.
what does this comment mean?
dashboard/dashboardserver/service.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func setupDashboardServerlogSink() hclog.Logger { |
There was a problem hiding this comment.
casing: setupDashboardServerLogSink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
steampipe service startAdds a
--dashboardflag tosteampipe service startwhich starts thedashboardserver with the steampipe service.Also adds support for
--dashboard-listenand--dashboard-portflags in theservice startcommand (ignored if--dashboardis not used).steampipe service startstarts the service only.steampipe service start --dashboardstarts the service and the dashboard serverif
steampipe service start --dashboardis given after asteampipe service startthen only thedashboardserver is started andpostgresis left untouchedsteampipe service stopStops both services if running - else stops only
postgresandpluginmanager--forceforce stops both (individually)steampipe service restartRestarts both (if running) else restarts only
postgres