Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use custom theme color yellow for severity cards, to avoid clashing with Tailwind's yellow palette. #3501

Closed
MichaelBurgess opened this issue May 30, 2023 · 0 comments
Assignees
Labels
bug Something isn't working dashboards ui

Comments

@MichaelBurgess
Copy link
Contributor

We currently have a theme colour yellow, which is used for the severity cards. We're not using any tailwind yellow colours in the CLI dashboard UI, but in Steampipe Cloud we use some yellow theme colours and if we try to include yellow into the theme, this overwrites the yellow family.

I propose we renamed this themed colour to severity to avoid any downstream issues such as this.

@MichaelBurgess MichaelBurgess added bug Something isn't working dashboards ui labels May 30, 2023
@MichaelBurgess MichaelBurgess self-assigned this May 30, 2023
@MichaelBurgess MichaelBurgess changed the title Dashboard UI severity cards should not use custom colour named yellow as this overwrites the tailwind yellow colour palette Don't use custom theme color yellow for severity cards, to avoid clashing with Tailwind's yellow palette. May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dashboards ui
Projects
None yet
Development

No branches or pull requests

1 participant