Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.timing does not print timing info when .output is set to anything other than table #3557

Closed
pskrbasu opened this issue Jun 12, 2023 · 1 comment · Fixed by #3560
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pskrbasu
Copy link
Contributor

.timing does not print timing info when .output is set to anything other than table.
Steps:

  • start interactive
  • .timing on
  • .output json
  • select * from aws_account

Does not show .timing info

@graza-io
Copy link
Contributor

graza-io commented Jun 12, 2023

This appears to be as expected based on this specific check which checks that cmdconfig.Viper().GetString(constants.ArgOutput) == constants.OutputFormatTable - @kaidaguerre / @binaek will know better if this is still intended behaviour.

Note: It would probably be worthwhile ensuring that JSON/CSV outputs only provide timing while in interactive mode as it would break the content format for example:
steampipe query "<some query>" --output=json --timing | jq <some jq func> would fail if we included the timing string.

@binaek binaek self-assigned this Jun 12, 2023
@binaek binaek added the bug Something isn't working label Jun 12, 2023
@binaek binaek added this to the 0.20.0 milestone Jun 12, 2023
@binaek binaek closed this as completed in 24c32e3 Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants