Removes naomi from debug mode #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit b935e08 replaced naomi with mailhog and it seems the naomi app was kept in INSTALLED_APPS declaration when DEBUG == True. Since in the referred commit the naomi dependency was removed from requirements file, the project is currently failing to run in debug mode in a fresh install. This change removes the naomi app from INSTALLED_APPS when DEBUG == True and removes the django-naomi dependency. Signed-off-by: Caio Carrara <eu@caiocarrara.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit b935e08 replaced naomi with mailhog and it seems the naomi
app was kept in INSTALLED_APPS declaration when DEBUG == True. Since in
the referred commit the naomi dependency was removed from requirements
file, the project is currently failing to run in debug mode in a fresh
install.
This change removes the naomi app from INSTALLED_APPS when DEBUG ==
True and removes the django-naomi dependency.