Porting rows to Python3 #151
Conversation
I couldn’t find where it’s used, so I’ve killed it.
I’ve ran `2to3 -x future .` Then I’ve checked the generated diffs looking for string types to use six. After that manual fixes I ran `2to3 -wn -x .` to process all python files.
|
Te amo <3 |
|
@henriquebastos, thank you very much for this! A general question: ee need something to test on more than one Python version. Do you think tox is right for this job? Is there any other better solution? I'm going to add some comments into the changed lines. |
| @@ -30,7 +30,7 @@ | |||
|
|
|||
|
|
|||
| def import_from_uwsgi_log(filename): | |||
| fields = UWSGI_FIELDS.keys() | |||
| fields = list(UWSGI_FIELDS.keys()) | |||
There was a problem hiding this comment.
I'm not sure we need all these list(). Could you please check it? They also happen in other files such as rows/cli.py.
There was a problem hiding this comment.
I think tox is a greate tool, @turicas
https://github.com/henriquebastos/rows/pull/1/files
|
@henriquebastos, code review done. Please check my comments -- meanwhile I'm going to run the tests on Python 2 and 3 to check the errors. :) |
|
I've just run the tests here and got these results:
Are these numbers expected? |
|
I'm closing this PR since the migration to support Python3 is already done and was released on version 0.3.0. |
This is a work in progress.
I could make all tests pass on Python3, but 3 are broken on Python2 because of something I can't find yet on the type identification system.
This PR is just to share it with you. Maybe your familiarity with the code can help fixing the tests.
[]'s!