Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text plugin is not working on rows convert #286

Closed
turicas opened this issue Jul 23, 2018 · 5 comments
Closed

Text plugin is not working on rows convert #286

turicas opened this issue Jul 23, 2018 · 5 comments
Labels
bug
Milestone
Version 0.4.0

Comments

@turicas
Copy link
Owner

turicas commented Jul 23, 2018

The file cha-de-bebe.txt is not being read correctly on the command line (try rows print cha-de-bebe.txt or rows convert cha-de-bebe.txt cha-de-bebe.csv) -- but it was generated correctly using rows print http://some-url/ > cha-de-bebe.txt.

@jsbueno could you please help checking it? I think this bug started after your PR #270 .
@turicas turicas added the bug label Jul 23, 2018
@jsbueno
Copy link
Collaborator

jsbueno commented Jul 23, 2018 •
edited

I will take a look at this

@turicas turicas added this to the Version 0.4.0 milestone Jul 23, 2018
@jsbueno
Copy link
Collaborator

jsbueno commented Aug 2, 2018 •
edited

I just created the PR #287 to fix this.

@jsbueno
Copy link
Collaborator

jsbueno commented Aug 4, 2018

I don't have the slightest idea of were I got the number '117' for that PR - but it does fix this issue.

@turicas
Copy link
Owner Author

turicas commented Sep 2, 2018

Fixed on f61cdfb. Thanks, @jsbueno!

@turicas turicas closed this as completed Sep 2, 2018
@jsbueno
Copy link
Collaborator

jsbueno commented Sep 3, 2018

Yay! Thanks to SciPy LA 2018 Sprint sessions!! (Although, all I did there was taking sometime to rebase the pull request and retest it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 0.4.0
Development

No branches or pull requests
2 participants
@turicas @jsbueno