Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unicodecsv by standard csv module #367

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jcapiitao
Copy link

@jcapiitao jcapiitao commented Jun 30, 2022

unicodecsv is not maintained since a while now [1].
It was preferred over standard csv because of the
unicode support. Now that Python3 csv module [2]
supports it, let's use it.

For more context, we hit issues while rebuilding
uncicodecsv during Fedora Python3.11 mass rebuild [3][4].

[1] https://github.com/jdunck/python-unicodecsv
[2] https://docs.python.org/3/library/csv.html
[3] https://copr.fedorainfracloud.org/coprs/g/python/python3.11/package/python-unicodecsv/
[4] https://bugzilla.redhat.com/show_bug.cgi?id=2021938

unicodecsv is not maintained since a while now [1].
It was preferred over standard csv because of the
unicode support. Now that Python3 csv module [2]
supports it, let's use it.

For more context, we hit issues while rebuilding
uncicodecsv during Fedora Python3.11 mass rebuild [3][4].

[1] https://github.com/jdunck/python-unicodecsv
[2] https://docs.python.org/3/library/csv.html
[3] https://copr.fedorainfracloud.org/coprs/g/python/python3.11/package/python-unicodecsv/
[4 https://bugzilla.redhat.com/show_bug.cgi?id=2021938]
@jsbueno jsbueno changed the base branch from develop to feature/queries June 30, 2022 22:14
@jsbueno jsbueno changed the base branch from feature/queries to develop June 30, 2022 22:14
@jsbueno
Copy link
Collaborator

jsbueno commented Jun 30, 2022

We are soon making changes that will remove any Python 2.x compatibility requirements on the develop branch.
When that is done, then we will merge this in.

@a-detiste
Copy link

yes please.
and unicodecsv is holding on unittest2 removal too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants