Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device tree configuration mistake breaks USB host support #9

Closed
CFSworks opened this issue Apr 19, 2023 · 3 comments · Fixed by #18
Closed

Device tree configuration mistake breaks USB host support #9

CFSworks opened this issue Apr 19, 2023 · 3 comments · Fixed by #18
Assignees
@CFSworks
Labels
bug Something isn't working
Milestone
Finish bmc applic...

Comments

@CFSworks
Copy link
Contributor

The OHCI/EHCI devices (needed for BMC to function as a USB host) are failing to bind their drivers, because the usb1-vbus regulator's driver can't bind. The kernel log says:

[    3.589216] sun8iw20-pinctrl 2000000.pinctrl: pin PB3 already requested by 2501000.uart; cannot claim for 2000000.pinctrl:35
[    3.601842] sun8iw20-pinctrl 2000000.pinctrl: pin-35 (2000000.pinctrl:35) status -22
[    3.610750] reg-fixed-voltage: probe of usb1-vbus failed with error -22

The device tree says the vbus regulator can be switched on/off with pin PB3, but on the actual board, PB3 is a serial line to node 3. I don't know how the board itself is wired, but it looks like this line has been moved to PG4?
@svenrademakers
Copy link
Collaborator

PB3 is wrong. As far as I can tell, your hypothesis. let me verify if PG4 is correct

@svenrademakers svenrademakers self-assigned this May 1, 2023
@CFSworks
Copy link
Contributor Author

CFSworks commented May 1, 2023

I have since learned that PG4 controls the 5V line in the external USB port, which should actually be disabled when the internal USB host is being used.

The usb1-vbus regulator should either be removed or replaced with a dummy. No 5V supply is needed to use internal USB.

@CFSworks
Copy link
Contributor Author

CFSworks commented May 1, 2023

Also, I am planning on rewriting the devicetree for #5 anyway. This one will be resolved when I do that - could you assign both that and this to me?

@CFSworks CFSworks mentioned this issue May 2, 2023
Merged
@svenrademakers svenrademakers added the bug Something isn't working label May 8, 2023
svenrademakers added a commit that referenced this issue May 17, 2023
@svenrademakers
Rewrite the devicetree (#18)
6532b6e 
This is a full rewrite of the devicetree to start to get things a little
more under control, and somewhat document what hardware is in there.
With these changes, I notice that Linux boots about 0.2 seconds faster,
too!

This is a draft because it is based on my restructured repository. The
.dts itself can of course be grabbed and used in the meantime. I have
also not yet tested a full image flash; this should not be used
seriously until someone can confirm that it doesn't upset U-Boot itself.

I am currently working under the 3-clause BSD license. Is that a
suitable FOSS license? Perhaps we should discuss with the community?

Fixes #5
Makes some progress on #7
Fixes #9
@svenrademakers svenrademakers added this to the Finish bmc application milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CFSworks CFSworks

Labels
bug Something isn't working
Projects
None yet
Milestone
Finish bmc application
Development

Successfully merging a pull request may close this issue.

Rewrite the devicetree
2 participants
@CFSworks @svenrademakers