Gh-10 rework pin controller #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenrademakers
force-pushed
the
feature/gpio_updates
branch
3 times, most recently
from
928c214
to
993ae1f
Compare
|
Fixed remaining issues with regard to the new DT. see turing-machines/BMC-Firmware#49 |
ruslashev
suggested changes
Jul 9, 2023
svenrademakers
force-pushed
the
feature/gpio_updates
branch
from
78bc661
to
79b2506
Compare
svenrademakers
force-pushed
the
feature/gpio_updates
branch
from
6c93902
to
dcc3d4f
Compare
Rework to accomodate changes in the linux subsystem by #49. Took the opportunity to go over the code once more and clean up the public methods of pin_controller and bmc_application.
the branch contains breaking changes because the library expect a new Linux device tree for the TP2. see #10 in BMC-Firmware repo
svenrademakers
force-pushed
the
feature/gpio_updates
branch
from
dcc3d4f
to
aecd055
Compare
ruslashev
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework that was done during debugging of #49. Mainly moved around code + small changes.
bmc_application.rs:229This commit cannot be used with the new Device tree of #49. My hypnosis is that there is an issue with the gpio aggregator, or buffered file writes, so for now i commit the user space changes that work on the current device tree.