Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme confusing example #129

Closed
Ken-B opened this issue Aug 18, 2020 · 1 comment · Fixed by #131
Closed

Readme confusing example #129

Ken-B opened this issue Aug 18, 2020 · 1 comment · Fixed by #131

Comments

@Ken-B
Copy link

Ken-B commented Aug 18, 2020

The current Readme section on Functions is a bit confusing.
In 1. we get a value of x = 0.7472542331020509, but in 2. the inverse gives z = 0.6543406780096065 and claims x == z.

I find that depending on your luck (or precision), x will not always equal z:

julia> using Random; Random.seed!(42);

julia> x = rand(dist)
0.36888689965963756

julia> y = link(dist, x)
-0.5369949942509267

julia> z = invlink(dist, y)
0.36888689965963756

julia> x==z
true

julia> using Random; Random.seed!(43);

julia> x = rand(dist)
0.3885220158396991

julia> y = link(dist, x)
-0.45352911444046184

julia> z = invlink(dist, y)
0.38852201583969914

julia> x == z
false

Maybe use \approx to show x ≈ z?

torfjelde added a commit that referenced this issue Aug 19, 2020
@torfjelde torfjelde linked a pull request Aug 19, 2020 that will close this issue
@torfjelde
Copy link
Member

Good idea; opened a PR to do:) Thanks!

torfjelde added a commit that referenced this issue Aug 19, 2020
* fix for #129

* fixed a value in the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants