Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add item tests methods en #955

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

Add item tests methods en #955

wants to merge 54 commits into from

Conversation

Ethan-t-n
Copy link

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Problem/feature

What problem are you trying to solve?
we were stuck on a method for update

Solution

How did you solve the problem?
we used an attr_accessor

Other changes (e.g. bug fixes, UI tweaks, small refactors)

Checklist

  • Code compiles correctly
  • Tests for the changes have been added (for bug fixes/features)
  • All tests passing
  • Extended the README / documentation, if necessary

bensjsilverstein and others added 30 commits June 1, 2022 11:52
@bensjsilverstein
Create class files and test files
cda41e9
@Ethan-t-n
Merge pull request #1 from Ethan-t-n/main
bf2cfdd 
Create class files and test files
@sdecesari
Inital commit
33c3324
@sdecesari
Merge branch 'master' of github.com:Ethan-t-n/black_thursday
029b0c8
@Ethan-t-n
initial commit
e7a402d
@Ethan-t-n
test 2
74c7434
@bensjsilverstein
Feat - Add 'exists' test
2e49e40
@bensjsilverstein
Feat - Create Merchant class
60132a6
@bensjsilverstein
Feat - Add id and name test
29adaf8
@bensjsilverstein
Feat - Add id and name methods
071c6a1
@bensjsilverstein
Feat - Add 'exists' test
6a18dd7
@bensjsilverstein
Feat - Add MerchantRepository class
3add087
@bensjsilverstein
Feat - Add test for 'all' method
e7b7710
@bensjsilverstein
Feat - Add 'all' method
78f3104
@bensjsilverstein
Fix -
b4e493e 
Adjust 'all' test to include count.
Adjust initialize to include more CSV path
@bensjsilverstein
Feat - Add 'find_by_id' test
05198a5
@bensjsilverstein
Fix -
cc806c1 
Adjust 'find_by_id' method
Adjust 'find_by_id' test
@bensjsilverstein
Feat - Add 'find_by_name' test
8bd70d5
@bensjsilverstein
Feat - Add 'find_by_name' method
92684cc
@bensjsilverstein
Feat - Add 'find_all_by_name' test
2a8c97f
@bensjsilverstein
Feat - Add 'find_all_by_name' method
b9677a6
@bensjsilverstein
Feat - Add 'create' test
6250075
@bensjsilverstein
Fix - remove 'create' from expect statements
4850cad
@bensjsilverstein
Fix - adjust 'create' test spacing
82ee722
@bensjsilverstein
Feat - Add MerchantRepository 'update' test
ebf0b70
@bensjsilverstein
Feat - Add MerchantRepository 'update' method
d0df47c
@bensjsilverstein
Fix - Adjust expect statement (remove .all)
848f221
@Ethan-t-n
Merge pull request #2 from Ethan-t-n/merchant_test_bjs
f88d7b7 
Merchant test bjs
@Ethan-t-n
Merge branch 'master' of github.com:Ethan-t-n/black_thursday
ebb0cb4
@bensjsilverstein
Feat - Add MerchantRepository 'delete' test
79a0df2
bensjsilverstein and others added 24 commits June 1, 2022 20:30
@bensjsilverstein
Feat - Add MerchantRepositroy 'delete' method
47c9135
@sdecesari
Merge pull request #3 from Ethan-t-n/add_merchantrepo_methods_and_tes…
19fcdef 
…ts_bjs

Add merchantrepo methods and tests bjs
@Ethan-t-n
Merge branch 'master' of github.com:Ethan-t-n/black_thursday
4e16cba
@Ethan-t-n
add test for item
ce83b14
@Ethan-t-n
add class for items
34a1d73
@Ethan-t-n
add unit_price_to_dollars
cad6c3d
@Ethan-t-n
add_price_to_dollar
9830779
@Ethan-t-n
add item repository initial test
3ac8f34
@Ethan-t-n
add class and inital spec test for item repository
5cf51a2
@Ethan-t-n
add .all method and .all test
044cf02
@Ethan-t-n
add can find id
1fabddf
@Ethan-t-n
refactor merchant repository
486b0a8
@Ethan-t-n
add test for find by id and find by name
978bddd
@Ethan-t-n
add test for find_all_with_description
42c3864
@Ethan-t-n
add test for find item by price
77fc04f
@Ethan-t-n
refactor finds item by price
94644c0
@Ethan-t-n
add test for find by merchant id
a28d33d
@Ethan-t-n
add test for create attributes
9ee2ab3
@Ethan-t-n
refactor merchant repository and add add method for item repo
f3ae5ea
@Ethan-t-n
add test for update
4af5e6a
@Ethan-t-n
add test for time in update test
3f388a9
@Ethan-t-n
fix name for update test
73ae959
@Ethan-t-n
add test for delete
d545a25
@Ethan-t-n
add method for delete
914cd6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ethan-t-n @bensjsilverstein @sdecesari