Joshua Aragon #191
Open
Joshua Aragon #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damwhit
reviewed
Sep 22, 2020
There was a problem hiding this comment.
@josharagon nice work getting things working! I think that you can stand to improve most in code style. I would try to find good examples of code in mdn and make sure that your white space and indentation match
| 'five','six','seven','eight','nine', 'ten'] | ||
|
|
||
| for (var i = numberOfFrogs; i > 0; --i) { | ||
| console.log(`${numberWords[i]} speckled frogs sat on a log |
There was a problem hiding this comment.
I believe the rhyme changes based on the number of frogs left. How would you account for that?
|
|
||
|
|
||
| for (var i=1; i < 101; i++){ | ||
| if (i % 15 == 0) console.log("FizzBuzz"); |
| @@ -16,11 +16,32 @@ class Burrito { | |||
| this.base = base; | |||
| this.toppings = toppings; | |||
| } | |||
|
|
|||
|
|
|||
| addTopping(topping){ | |||
There was a problem hiding this comment.
I would check indentation matches with your example classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my prework!
gear up: https://gist.github.com/josharagon/b6e33fca65875f6fdb747305bc96c1e3
technical: https://github.com/josharagon/frontend-mod-1-prework/