-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patrick Findley #203
base: master
Are you sure you want to change the base?
Patrick Findley #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid work on the prework. I recommend going back with a fine-toothed comb to identify and fix any syntax issues (I highlighted a few but saw several others).
Great work on the FizzBuzz and Frog problem - be sure to check my notes for how you could refactor.
} | ||
} | ||
|
||
var speckledFrog = new NurseryRhyme("speckled frogs", "speckled frog", 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on arriving at a solution to this problem!
Interesting choice to use a class to set this up - you'll learn more about this in Mod 1, but classes can sometimes be a little heavy-handed for this particular use case. One thing I want you to review is how you can use parameters with a function to achieve the same thing you did with this class example! For context, functions are more lightweight than classes and in fact, classes are actually functions under the hood.
This could be a great opportunity to refactor this into a function that uses parameters instead of setting up an entire class.
this.length = ""; this.width = "x "; | ||
``` | ||
3. well, we both know this doesn't work, and isn't the right approach. | ||
* after looking googling this program a little I was pleased to at least see I wasn't on the WRONG track, just needed to think on a larger scale for each dimension seperately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the Checkerboard class you created something you found online or something you created yourself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absolutely something I found. I found one I understood and made my own referencing it.
day_6/questions.md
Outdated
|
||
1. In the space below, create a Car class with at least 2 attributes and 2 methods | ||
* ```JavaScript | ||
class car { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All classes should be in PascalCase
console.log("clicky sound"); | ||
} | ||
shiftUp() { | ||
this.gear = ++this.gear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check syntax on this...
Here is my pre-work!