Robby DeRouin Mod 1 Prework #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francepack
reviewed
Jan 18, 2021
| removeTopping(topping) { | ||
| for (var i = 0; i < this.toppings.length; i++){ | ||
| if (this.toppings[i]==topping){ | ||
| this.toppings.splice(i,1); |
There was a problem hiding this comment.
Nice job iterating through your toppings to find one that matches the topping to remove!
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Nice work setting this up in a function that can be run for any number of frogs! Don't forget the special circumstance for when i = 2: the language is slightly different there!
Also, I suggest putting special cases in the if/elseif block... I would put the 'default' condition in the last else block. Right now, it seems like the most hit condition is in the first block.
| @@ -0,0 +1,10 @@ | |||
| function checkerBoard (checkers){ | |||
| for (var i = 1; i <= checkers; i++) { | |||
| if (i % 2 === 0){ | |||
There was a problem hiding this comment.
You may need a loop within your loop if you want the ability to change the length of your rows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my Mod 1 Prework